Increase cartesian planning timeout to accommodate slower machines#9
Closed
nikkijhart wants to merge 2 commits intohumble-develfrom
Closed
Increase cartesian planning timeout to accommodate slower machines#9nikkijhart wants to merge 2 commits intohumble-develfrom
nikkijhart wants to merge 2 commits intohumble-develfrom
Conversation
eholum-nasa
reviewed
Nov 13, 2025
| ur_manipulator: | ||
| kinematics_solver: trac_ik_kinematics_plugin/TRAC_IKKinematicsPlugin | ||
| kinematics_solver_timeout: 0.005 | ||
| kinematics_solver_timeout: 0.05 |
Member
There was a problem hiding this comment.
I think that Trac IK in distance mode will use the full time allotment for each solve - you can follow the param down to here (I am not 100% sure so would ask you to confirm that):
So I am a bit loathe to up this across the board... But maybe it would be worth it to change these to speed?
Collaborator
Author
|
@eholum-nasa Updated timeout based on further testing |
Member
|
Updated specifically for that one demo, here: NASA-JSC-Robotics/clr_sim_demos#7 I think this is good to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for NASA-JSC-Robotics/clr_sim_demos#2. Hopefully this doesn't impact those with faster machines--in theory, this should be the upper limit, not the time required to plan. Maybe @eholum-nasa can test and verify?